AutoFill Profiles dialog handles multi-select and delete on Mac

AutoFill Profiles dialog handles multi-select and delete on Mac

Changes the AutoFill dialog on Mac to support multi-select and delete of items
in the address and credit card table.  The "Edit..." button disables when multiple
items are selected.

Nib changes in AutoFillDialog.xib: (1) Enables multi-select for the table view, (2) binds
the enabled state of the "Edit..." button to the new |multipleSelected| property, (3) connects edit button to outlet.

BUG=49344, 46075
TEST=AutoFillDialogControllerTest.DeleteMultiple.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52989

[John Grabowski, 2010-07-20 00:10:23]

LGTM

http://codereview.chromium.org/3039014/diff/1/4
File chrome/browser/autofill/autofill_dialog_controller_mac.mm (right):

http://codereview.chromium.org/3039014/diff/1/4#newcode341
chrome/browser/autofill/autofill_dialog_controller_mac.mm:341: // Deletes
selected items, either addresses, credit cards, or a mixture of the
Deletes selected items;

http://codereview.chromium.org/3039014/diff/1/5
File chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm (right):

http://codereview.chromium.org/3039014/diff/1/5#newcode517
chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm:517:
[controller_ addSelectedCreditCardAtIndex:0];
ASSERT edit button enabled at this point

http://codereview.chromium.org/3039014/diff/1/5#newcode518
chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm:518:
[controller_ deleteSelection:nil];
ASSERT edit button disabled

[dhollowa, 2010-07-20 00:31:35]

http://codereview.chromium.org/3039014/diff/1/4
File chrome/browser/autofill/autofill_dialog_controller_mac.mm (right):

http://codereview.chromium.org/3039014/diff/1/4#newcode341
chrome/browser/autofill/autofill_dialog_controller_mac.mm:341: // Deletes
selected items, either addresses, credit cards, or a mixture of the
On 2010/07/20 00:10:23, John Grabowski wrote:
> Deletes selected items;
> 

Done.

http://codereview.chromium.org/3039014/diff/1/5
File chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm (right):

http://codereview.chromium.org/3039014/diff/1/5#newcode517
chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm:517:
[controller_ addSelectedCreditCardAtIndex:0];
On 2010/07/20 00:10:23, John Grabowski wrote:
> ASSERT edit button enabled at this point

Done.

http://codereview.chromium.org/3039014/diff/1/5#newcode518
chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm:518:
[controller_ deleteSelection:nil];
On 2010/07/20 00:10:23, John Grabowski wrote:
> ASSERT edit button disabled
> 

Done.

[Nico, 2010-07-20 03:18:20]

http://codereview.chromium.org/3039014/diff/13001/14003
File chrome/browser/autofill/autofill_dialog_controller_mac.mm (right):

http://codereview.chromium.org/3039014/diff/13001/14003#newcode368
chrome/browser/autofill/autofill_dialog_controller_mac.mm:368: for (NSInteger i
= rowCount-1; i>=0; --i) {
You want:

    for (NSUInteger i = [selection lastIndex];
       i != NSNotFound;
       i = [selection indexLessThanIndex:i]) {