Issue 3039005: Fix some issues with extensions:

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3039005: Fix some issues with extensions: (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Matt Perry

Modified:
4 years ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Erik does not do reviews, arv, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Fix some issues with extensions: - Default to Allow file permissions for unpacked extensions. - Fix incognito warning display when extensions are reshuffled. - Remove SCHEMES_ALL BUG=48124 BUG=48526 BUG=49243 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52974

Patch Set 1 #

Patch Set 2 : remove schemes_all #

Total comments: 3

Patch Set 3 : fix host perms #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -41 lines)			Patch
M	chrome/browser/extensions/crx_installer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/extensions_ui.html	View		3 chunks	+16 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension.cc	View	2	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/common/extensions/extension_extent_unittest.cc	View		4 chunks	+15 lines, -10 lines	0 comments	Download
M	chrome/common/extensions/url_pattern.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/url_pattern_unittest.cc	View		13 chunks	+28 lines, -21 lines	0 comments	Download
M	chrome/common/extensions/user_script_unittest.cc	View		4 chunks	+11 lines, -4 lines	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

http://codereview.chromium.org/3039005/diff/2001/3003 File chrome/browser/resources/extensions_ui.html (right): http://codereview.chromium.org/3039005/diff/2001/3003#newcode514 chrome/browser/resources/extensions_ui.html:514: if (extension.extensionId != warnings[i].attachedExtensionId) { Ah, you found a ...

4 years, 10 months ago (2010-07-16 19:45:56 UTC) #2

Matt Perry

http://codereview.chromium.org/3039005/diff/2001/3004 File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/3039005/diff/2001/3004#newcode1404 chrome/common/extensions/extension.cc:1404: URLPattern pattern(UserScript::kValidUserScriptSchemes); On 2010/07/16 19:45:56, Aaron Boodman wrote: > ...

4 years, 10 months ago (2010-07-16 20:43:18 UTC) #3

lgtm

Expand Messages | Collapse Messages