Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Unified Diff: chrome/browser/resources/extensions_ui.html

Issue 3039005: Fix some issues with extensions: (Closed)
Patch Set: fix host perms Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extensions_service.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/extensions_ui.html
diff --git a/chrome/browser/resources/extensions_ui.html b/chrome/browser/resources/extensions_ui.html
index 7b58fae236260446ac3895792543bec14eb4283d..5e9b020de4edf2efdd2d66f3314061940ea9e5c9 100644
--- a/chrome/browser/resources/extensions_ui.html
+++ b/chrome/browser/resources/extensions_ui.html
@@ -503,6 +503,20 @@ function returnExtensionsData(extensionsData){
for (var i = 0; i < slidables.length; i++)
slidables[i].style.height = slidables[i].offsetHeight + 'px';
+ // Hide all the incognito warnings that are attached to the wrong extension
+ // ID, which can happen when an extension is added or removed.
+ var warnings = document.getElementsByClassName('incognitoWarning');
+ for (var i = 0; i < warnings.length; i++) {
+ var extension = warnings[i];
+ while (extension.className != "extension")
+ extension = extension.parentNode;
+
+ if (extension.extensionId != warnings[i].attachedExtensionId) {
+ warnings[i].style.display = "none";
+ warnings[i].style.opacity = "0";
+ }
+ }
+
// Reset visibility of page based on the current dev mode.
document.getElementById('collapse').style.display =
devModeExpanded ? 'inline' : 'none';
@@ -571,6 +585,7 @@ function handleToggleExtensionIncognito(node) {
warning.style.display = "none";
warning.style.opacity = "0";
} else {
+ warning.attachedExtensionId = node.extensionId;
warning.style.display = "block";
// Must set the opacity later. Otherwise, the fact that the display is
@@ -805,7 +820,7 @@ document.addEventListener('DOMContentLoaded', requestExtensionsData);
</div>
<div jsdisplay="extensions.length > 0">
- <div class="extension" jsselect="extensions">
+ <div class="extension" jsselect="extensions" jsvalues=".extensionId:id">
<table width="100%" cellpadding="2" cellspacing="0">
<tr jsvalues=".className:enabled ? 'extension_enabled' : 'extension_disabled'">
<td width="62" height="50" align="center" valign="top">
« no previous file with comments | « chrome/browser/extensions/extensions_service.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698