Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 303873003: Fix invalid expectation in unittest. (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Fix invalid expectation in unittest. TBR=sky@chromium.org BUG=vtl's bitching Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Ben Goodger (Google)
6 years, 6 months ago (2014-05-28 19:35:38 UTC) #1
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 6 months ago (2014-05-28 19:35:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/303873003/1
6 years, 6 months ago (2014-05-28 19:36:49 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 22:49:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 23:10:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157720)
6 years, 6 months ago (2014-05-28 23:10:11 UTC) #6
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 6 months ago (2014-05-29 05:08:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/303873003/1
6 years, 6 months ago (2014-05-29 05:08:58 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 06:59:19 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 08:44:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157923)
6 years, 6 months ago (2014-05-29 08:44:32 UTC) #11
Ben Goodger (Google)
6 years, 6 months ago (2014-05-30 05:23:34 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 manually as r273720 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698