Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 30383002: Merge 159961 "Defer the real work in updateCompositingLayers unt..." (Closed)

Created:
7 years, 2 months ago by kareng
Modified:
7 years, 2 months ago
Reviewers:
shawnsingh
CC:
blink-reviews, blink-layers+watch_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, zoltan1, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, jchaffraix+rendering, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Merge 159961 "Defer the real work in updateCompositingLayers unt..." > Defer the real work in updateCompositingLayers until it's really needed. > > Many types of change on a web page end up requiring that > compositing state gets updated. Currently this work is performed > immediately after layout, recalcStyle, and other entry points. > > However, this work may happen surprisingly many times per actual > rendered frame, which is absolutely wasteful - nothing except the > most recent compositing state will matter when the frame finally > gets drawn. So, instead we can defer all compositing update work > until the compositor is ready to ask for updated compositing state. > > BUG=229679, 302726 > R=jamesr@chromium.org, vollick@chromium.org > > Review URL: https://codereview.chromium.org/26110004 TBR=shawnsingh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -72 lines) Patch
M LayoutTests/compositing/gestures/gesture-tapHighlight-on-promoted-overflow-div-scrolled.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-sibling-display-change.html View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling-after-sibling-z-index-change.html View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/dynamic-composited-scrolling-status.html View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/compositing/overflow/opt-into-composited-scrolling-positioned-ancestor.html View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/compositing/overflow/resources/automatically-opt-into-composited-scrolling.js View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-inside-composited-intermediate-layer.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-composited-child.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/events/touch/resources/compositor-touch-hit-rects.js View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html View 1 chunk +5 lines, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderGeometryMap.cpp View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderLayer.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 5 chunks +14 lines, -17 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.h View 5 chunks +13 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 14 chunks +56 lines, -24 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 2 chunks +20 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 10 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 2 months ago (2013-10-19 04:07:27 UTC) #1
kareng
7 years, 2 months ago (2013-10-19 04:08:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r159993.

Powered by Google App Engine
This is Rietveld 408576698