Issue 303813003: Revert "Remove SkThread.h from public API."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303813003: Revert "Remove SkThread.h from public API." (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
mtklein, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Revert "Remove SkThread.h from public API." Too much depends on SkThread being in include/core in Chrome build. This reverts commit b1aec17df6078115c797839c9646081ccba2bd09. NOTREECHECKS=true NOTRY=true TBR=reed BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14934

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -127 lines)			Patch
M	include/core/SkInstCnt.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkOnce.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	include/core/SkRefCnt.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
A +	include/core/SkThread.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	include/core/SkWeakRefCnt.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/GrBackendEffectFactory.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
D	src/core/SkThread.h	View	1 chunk	+0 lines, -117 lines	0 comments	Download
M	src/views/SkEvent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/views/SkEventSink.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/views/SkOSMenu.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/303813003/1

6 years, 6 months ago (2014-05-28 20:02:09 UTC) #3

Message was sent while issue was closed.

Change committed as 14934

Expand Messages | Collapse Messages