Source/core/html/HTMLCanvasElement.cpp - Issue 303803002: Prevent <canvas> destructor from causing nested garbage collection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCanvasElement.cpp

Issue 303803002: Prevent <canvas> destructor from causing nested garbage collection (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLCanvasElement.cpp

diff --git a/Source/core/html/HTMLCanvasElement.cpp b/Source/core/html/HTMLCanvasElement.cpp

index 737f7fb5fea854996ca309abbd6bfbdc52ab697f..9b67ff43787a43927977af725a7c7a65dd0b646a 100644

--- a/Source/core/html/HTMLCanvasElement.cpp

+++ b/Source/core/html/HTMLCanvasElement.cpp

@@ -567,10 +567,8 @@ GraphicsContext* HTMLCanvasElement::drawingContext() const

GraphicsContext* HTMLCanvasElement::existingDrawingContext() const

{

- if (m_didFailToCreateImageBuffer) {

- ASSERT(!hasImageBuffer());

+ if (!hasImageBuffer())

return 0;

- }

return drawingContext();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »