Issue 303783002: [DevTools] Beautified device counter icon.

Issue 303783002: [DevTools] Beautified device counter icon. (Closed)

Created:
6 years, 6 months ago by Dmitry Zvorygin

Modified:
6 years, 6 months ago

Reviewers:
vsevik, apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[DevTools] Beautified device counter icon. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175106

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed style #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	Source/devtools/front_end/components/InspectorView.js	View	1	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

apavlov

lgtm with a nit https://codereview.chromium.org/303783002/diff/1/Source/devtools/front_end/components/InspectorView.js File Source/devtools/front_end/components/InspectorView.js (right): https://codereview.chromium.org/303783002/diff/1/Source/devtools/front_end/components/InspectorView.js#newcode469 Source/devtools/front_end/components/InspectorView.js:469: var count = /** @type ...

6 years, 6 months ago (2014-05-29 13:26:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/303783002/20001

6 years, 6 months ago (2014-05-29 13:51:01 UTC) #5

Dmitry Zvorygin

https://codereview.chromium.org/303783002/diff/1/Source/devtools/front_end/components/InspectorView.js File Source/devtools/front_end/components/InspectorView.js (right): https://codereview.chromium.org/303783002/diff/1/Source/devtools/front_end/components/InspectorView.js#newcode469 Source/devtools/front_end/components/InspectorView.js:469: var count = /** @type {number} */(event.data); On 2014/05/29 ...

6 years, 6 months ago (2014-05-29 14:55:44 UTC) #6

Message was sent while issue was closed.

Change committed as 175106

Expand Messages | Collapse Messages