Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1927)

Unified Diff: ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc

Issue 303723003: Lock Rotation on user settings changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also update current rotation Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
diff --git a/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc b/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
index 347499f610ff0870096dd5a5f64b48ee1e2e941d..5e7c458281988aeed3fb101847a61ce2c926ebcc 100644
--- a/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
+++ b/ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc
@@ -115,19 +115,19 @@ TEST_F(TrayRotationLockTest, CreateTrayViewDuringMaximizeMode) {
TEST_F(TrayRotationLockTest, CreateTrayViewDuringMaximizeModeAndRotationLock) {
TearDownViews();
Shell::GetInstance()->EnableMaximizeModeWindowManager(true);
- Shell::GetInstance()-> maximize_mode_controller()->set_rotation_locked(true);
+ Shell::GetInstance()-> maximize_mode_controller()->SetRotationLocked(true);
SetUpForStatusAreaWidget(StatusAreaWidgetTestHelper::GetStatusAreaWidget());
EXPECT_TRUE(tray_view()->visible());
Shell::GetInstance()->EnableMaximizeModeWindowManager(false);
+ EXPECT_FALSE(tray_view()->visible());
}
// Tests that the enabling of MaximizeMode affects a previously created tray
// view, changing the visibility.
TEST_F(TrayRotationLockTest, TrayViewVisibilityChangesDuringMaximizeMode) {
- TearDownViews();
+ ASSERT_FALSE(tray_view()->visible());
Shell::GetInstance()->EnableMaximizeModeWindowManager(true);
- Shell::GetInstance()-> maximize_mode_controller()->set_rotation_locked(true);
- SetUpForStatusAreaWidget(StatusAreaWidgetTestHelper::GetStatusAreaWidget());
+ Shell::GetInstance()-> maximize_mode_controller()->SetRotationLocked(true);
EXPECT_TRUE(tray_view()->visible());
Shell::GetInstance()->EnableMaximizeModeWindowManager(false);
EXPECT_FALSE(tray_view()->visible());

Powered by Google App Engine
This is Rietveld 408576698