Issue 3037051: [Isolates] Added specific check for Fibonacci results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3037051: [Isolates] Added specific check for Fibonacci results. (Closed)

Created:
10 years, 4 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Visibility:
Public.

Description

[Isolates] Added specific check for Fibonacci results. This is a follow-up to code review http://codereview.chromium.org/2836067/show, I forgot to fix this before landing. Committed: http://code.google.com/p/v8/source/detail?r=5199

Patch Set 1 #

Total comments: 1

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	test/cctest/test-api.cc	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

10 years, 4 months ago (2010-08-06 20:43:14 UTC) #2

LGTM

http://codereview.chromium.org/3037051/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/3037051/diff/1/2#newcode11427
test/cctest/test-api.cc:11427: // (I'm lazy!) from
http://en.wikipedia.org/wiki/Fibonacci_number
http://www.wolframalpha.com/input/?i=fibonacci+21 :)

Expand Messages | Collapse Messages