Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 303703002: Revert 272980 "NaCl: Update revision in DEPS, r13226 -> r13245" (Closed)

Created:
6 years, 7 months ago by Dan Beam
Modified:
6 years, 7 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 272980 "NaCl: Update revision in DEPS, r13226 -> r13245" Seems to have broken some ChromeOS bots with this error: dump_syms: /var/tmp/portage/chromeos-base/google-breakpad-1303-r82/work/google-breakpad-1303/src/common/dwarf/dwarf2reader.cc:188: const char* dwarf2reader::CompilationUnit::SkipAttribute(const char*, dwarf2reader::DwarfForm): Assertion `header_.version == 2 || header_.version == 3' failed. > NaCl: Update revision in DEPS, r13226 -> r13245 > > This pulls in the following Native Client changes: > > r13227: (dyen) Standardized method to define extra substitution paths in toolchain_main. > r13228: (dschuff) Do not build PNaCl host toolchain with build.sh > r13229: (sbc) Add downloaded gn binaries to .gitignore > r13230: (dschuff) Remove cloud-bucket flag from PNaCl package_version update script > r13231: (bradnelson) Download spec2k to out instead of assuming it will be installed on the bots. > r13232: (dschuff) Make build.sh use the repository directories from toolchain/build > r13233: (jvoung) Download the spec harness on the rest of the spec bots. > r13234: (sehr) Disable conflicting sysroot= in chromium arm build > r13235: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r13236: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r13237: (dschuff) Update revision for PNaCl r13222->r13228 > r13238: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r13239: (mcgrathr) toolchain_build: Update gcc revision (4.8.3 release) > r13240: (mseaborn) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r13241: (noelallen) Add OWNERS per-file *.gn for noeallen and bradnelson > r13242: (noelallen) Untar raw toolchain and build cooked toolchain. > r13243: (mcgrathr) Update nacl_arm_newlib toolchain > r13244: (dyen) Toolchain build now displays solutions when an invalid repo is found. > r13245: (mseaborn) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > > BUG=none > TEST=browser_tests and nacl_integration > > Review URL: https://codereview.chromium.org/300033004 TBR=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Dan Beam
6 years, 7 months ago (2014-05-27 20:37:24 UTC) #1
Dan Beam
6 years, 7 months ago (2014-05-27 20:37:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273017 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698