Code review changes for r36718.

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 0c72a1b89de7511c1f8f1448a827608769e5bf6a..e28920a5fb144696c1b8d47472795c2c43de8aee 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -402,7 +402,10 @@ abstract class TestSuite {
      *      third_party/pkg/PACKAGE_NAME
      */
 
-    isValid(packageName) => packageName != 'third_party';
+    // Packages that contain "-" in their names are pinned to specific versions.
+    // We can ignore those for the purposes of testing.

[kustermann, 2014/05/28 07:13:57]

This comment is misleading (as I already mentioned in the first CL). I think a
better comment would be:

// Directories containing "-" are not valid dart packages and we
// therefore do not include them in the list of packages.

[nweiz, 2014/05/28 20:33:27]

Done.

+    isValid(packageName) =>
+        packageName != 'third_party' && !packageName.contains('-');
 
     var dartDir = TestUtils.dartDir;
     var futures = [
@@ -415,11 +418,6 @@ abstract class TestSuite {
       for (var result in results) {
         for (var packageTuple in result) {
           String packageName = packageTuple[0];
-
-          // Some packages are pinned to specific versions. We can ignore those
-          // for the purposes of testing.
-          if (packageName.contains('-')) continue;
-
           String fullPath = packageTuple[1];
           String yamlFile =
               new Path(fullPath).append('pubspec.yaml').toNativePath();