Code review changes for r36718.

Code review changes for r36718.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=36765

[kustermann, 2014-05-28 07:13:57]

LGTM with comment.

https://codereview.chromium.org/303693006/diff/1/tools/testing/dart/test_suit...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/303693006/diff/1/tools/testing/dart/test_suit...
tools/testing/dart/test_suite.dart:406: // We can ignore those for the purposes
of testing.
This comment is misleading (as I already mentioned in the first CL). I think a
better comment would be:

// Directories containing "-" are not valid dart packages and we
// therefore do not include them in the list of packages.

[kustermann, 2014-05-28 07:14:30]

And thank you for this follow up CL.

[nweiz, 2014-05-28 20:33:27]

https://codereview.chromium.org/303693006/diff/1/tools/testing/dart/test_suit...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/303693006/diff/1/tools/testing/dart/test_suit...
tools/testing/dart/test_suite.dart:406: // We can ignore those for the purposes
of testing.
On 2014/05/28 07:13:57, kustermann wrote:
> This comment is misleading (as I already mentioned in the first CL). I think a
> better comment would be:
> 
> // Directories containing "-" are not valid dart packages and we
> // therefore do not include them in the list of packages.

Done.

[nweiz, 2014-05-28 20:37:48]

Committed patchset #2 manually as r36765 (presubmit successful).