Source/bindings/v8/V8PerIsolateData.h - Issue 303693005: Simplify Blink <-> V8 Microtask queue running protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8PerIsolateData.h

Issue 303693005: Simplify Blink <-> V8 Microtask queue running protocol (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8PerIsolateData.h

diff --git a/Source/bindings/v8/V8PerIsolateData.h b/Source/bindings/v8/V8PerIsolateData.h

index 1f7bdfa2a0f70731b2f7dcfa0c0973d4d2f4f860..ce8c70649aadb6cc94f02eaa0069f27c62ad6200 100644

--- a/Source/bindings/v8/V8PerIsolateData.h

+++ b/Source/bindings/v8/V8PerIsolateData.h

@@ -92,7 +92,7 @@ public:

bool hasInstance(const WrapperTypeInfo*, v8::Handle<v8::Value>);

v8::Handle<v8::Object> findInstanceInPrototypeChain(const WrapperTypeInfo*, v8::Handle<v8::Value>);

- // FIXME: This method should go away, because we shouldn't need a random context to be able to run microtasks.

+ // FIXME: This method should go away, because we shouldn't need a random context to be able to enqueue microtasks.

v8::Local<v8::Context> ensureDomInJSContext();

const char* previousSamplingState() const { return m_previousSamplingState; }