chrome/test/data/nacl/manifest_file/irt_manifest_file_test.html - Issue 303683005: Add failure case for manifest file testing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/nacl/manifest_file/irt_manifest_file_test.html

Issue 303683005: Add failure case for manifest file testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc ('K') | « chrome/test/data/nacl/manifest_file/irt_manifest_file_test.cc ('k') | chrome/test/data/nacl/nacl_test_data.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!--	1 <!--

2 Copyright 2014 The Chromium Authors. All rights reserved.	2 Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can	3 Use of this source code is governed by a BSD-style license that can

4 be found in the LICENSE file.	4 be found in the LICENSE file.

5 -->	5 -->

6 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"	6 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"

7 "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">	7 "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

8 <html>	8 <html>

9 <head>	9 <head>

10 <meta http-equiv="Pragma" content="no-cache" />	10 <meta http-equiv="Pragma" content="no-cache" />

(...skipping 22 matching lines...) Expand all Loading...
33 }	33 }

34 var embed = createModule('naclModule', 'irt_manifest_file.nmf', mime);	34 var embed = createModule('naclModule', 'irt_manifest_file.nmf', mime);

35 embed.basic_tests ='2';	35 embed.basic_tests ='2';

36 embed.stress_tests = '0';	36 embed.stress_tests = '0';

37 document.body.appendChild(embed);	37 document.body.appendChild(embed);

38	38

39 function setupTests(tester, plugin) {	39 function setupTests(tester, plugin) {

40 tester.addAsyncTest('Test_00_Init', function(status) {	40 tester.addAsyncTest('Test_00_Init', function(status) {

41 plugin.addEventListener('message', function(message_event) {	41 plugin.addEventListener('message', function(message_event) {

42 this.removeEventListener('message', arguments.callee, false);	42 this.removeEventListener('message', arguments.callee, false);

43 var golden = 'File Contents:\nTest File Content';	43 var golden = [

	44 'File Contents:\nTest File Content',

	45 // 2 is an error code for ENOENT.
	Mark Seaborn 2014/05/29 16:55:48 Hard-coding a numeric errno value here isn't very Hard-coding a numeric errno value here isn't very clean. It would be better if you could just check for a result like "passed" here. See other comment. hidehiko 2014/05/30 04:49:58 Done. Show quoted text On 2014/05/29 16:55:48, Mark Seaborn wrote: > Hard-coding a numeric errno value here isn't very clean. It would be better if > you could just check for a result like "passed" here. See other comment. Done.
	46 'open_resource() result: 2',

	47 'open_resource() result: 2',

	48 ];

44 status.assertEqual(message_event.data, golden);	49 status.assertEqual(message_event.data, golden);

45 status.pass();	50 status.pass();

46 }, false);	51 }, false);

47 plugin.postMessage('hello');	52 plugin.postMessage('hello');

48 });	53 });

49 }	54 }

50	55

51 var tester = new Tester();	56 var tester = new Tester();

52 setupTests(tester, $('naclModule'));	57 setupTests(tester, $('naclModule'));

53 tester.waitFor($('naclModule'));	58 tester.waitFor($('naclModule'));

54 tester.run();	59 tester.run();

55 //]]>	60 //]]>

56 </script>	61 </script>

57 </body>	62 </body>

58 </html>	63 </html>

OLD	NEW