Issue 303653005: Remove frame disconnection counter updating in removeDetachedChildren()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303653005: Remove frame disconnection counter updating in removeDetachedChildren() (Closed)

Created:
6 years, 7 months ago by esprehn

Modified:
6 years, 6 months ago

Reviewers:
ojan, eseidel

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove frame disconnection counter updating in removeDetachedChildren() This method is only called from destructors or document teardown. We apparenly also skip it when in Oilpan mode. That would seem to indicate that by the time we get here there should be no subframes left connected. Lets change the loop into an ASSERT to verify that. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175086