Issue 303643005: Straighten up HTML Imports load vs. share loader logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303643005: Straighten up HTML Imports load vs. share loader logic. (Closed)

Created:
6 years, 6 months ago by dglazkov

Modified:
6 years, 6 months ago

Reviewers:
Hajime Morrita, gmorrita

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Straighten up HTML Imports load vs. share loader logic. This is just moving code around in preparation for making HTMLImportController not being a root HTMLImport. R=morrita BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175002

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -46 lines)			Patch
M	Source/core/html/imports/HTMLImportChild.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportChild.cpp	View	3 chunks	+5 lines, -28 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportsController.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/imports/HTMLImportsController.cpp	View	4 chunks	+17 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/303643005/1

6 years, 6 months ago (2014-05-28 20:53:09 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...

6 years, 6 months ago (2014-05-28 22:14:04 UTC) #5

Message was sent while issue was closed.

Change committed as 175002

Expand Messages | Collapse Messages