Issue 30363003: Fix crash in GeolocationController when the page gets destroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 30363003: Fix crash in GeolocationController when the page gets destroyed (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit), adamk, abarth-chromium

CC:
blink-reviews, Michael van Ouwerkerk, adamk

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix crash in GeolocationController when the page gets destroyed Fix crash in GeolocationController when the page gets destroyed by checking that page() does not return null before using it. BUG=310326 TEST=fast/dom/Geolocation/window-close-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160351

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/modules/geolocation/GeolocationController.cpp	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm https://codereview.chromium.org/30363003/diff/1/Source/modules/geolocation/GeolocationController.cpp File Source/modules/geolocation/GeolocationController.cpp (right): https://codereview.chromium.org/30363003/diff/1/Source/modules/geolocation/GeolocationController.cpp#newcode138 Source/modules/geolocation/GeolocationController.cpp:138: if (page() && page()->visibilityState() == PageVisibilityStateVisible) I'd hope ...

7 years, 2 months ago (2013-10-23 15:34:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/30363003/1

7 years, 2 months ago (2013-10-23 15:39:42 UTC) #4

Message was sent while issue was closed.

Change committed as 160351

Expand Messages | Collapse Messages