Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 303603004: sync: Separate .gyp file for standalone tools (Closed)

Created:
6 years, 7 months ago by rlarocque
Modified:
6 years, 6 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, pavely
Visibility:
Public.

Description

sync: Separate .gyp file for standalone tools Moves targets related to the standalone executables sync_listen_notifications and sync_client into their own .gyp file. This will prevent a temporary circular dependency as we attempt to invert the dependency from components/invalidation -> sync towards sync -> components/invalidation. BUG=378024 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273665

Patch Set 1 #

Patch Set 2 : Re-arrange for iOS #

Patch Set 3 : Move the new gyp file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -64 lines) Patch
M build/all.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sync/sync_tests.gypi View 2 chunks +0 lines, -64 lines 0 comments Download
A sync/tools/sync_tools.gyp View 1 2 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rlarocque
I think this fixes the circular dependency that is currently blocking https://codereview.chromium.org/294123004/. Please review.
6 years, 6 months ago (2014-05-28 19:40:06 UTC) #1
rlarocque
Updated as discussed.
6 years, 6 months ago (2014-05-28 20:47:18 UTC) #2
maniscalco
lgtm
6 years, 6 months ago (2014-05-29 21:46:53 UTC) #3
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 6 months ago (2014-05-29 21:51:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/303603004/40001
6 years, 6 months ago (2014-05-29 21:52:47 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 22:37:35 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 23:47:13 UTC) #7
Message was sent while issue was closed.
Change committed as 273665

Powered by Google App Engine
This is Rietveld 408576698