Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 303593002: Oilpan: prevent player from accessing its media element during finalization (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rephrase player finalization as detaching Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMediaElement.cpp
diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp
index 0a8cab5474df71b56555b93d3a1b7a185cae76d1..ed4226fb448e9d9999b9892859683647ffb746b6 100644
--- a/Source/core/html/HTMLMediaElement.cpp
+++ b/Source/core/html/HTMLMediaElement.cpp
@@ -363,6 +363,14 @@ HTMLMediaElement::~HTMLMediaElement()
document().incrementLoadEventDelayCount();
#endif
+#if ENABLE(OILPAN)
+ // Oilpan: the player must be released, but it cannot safely access
haraken 2014/05/27 23:09:09 but => because ?
+ // this client any longer as parts of it may have been finalized
+ // already (like the media element's supplementable table.)
+ // Detach and render the client inaccessible first.
+ if (m_player)
+ m_player->detach();
+#endif
clearMediaPlayerAndAudioSourceProviderClient();
#if !ENABLE(OILPAN)

Powered by Google App Engine
This is Rietveld 408576698