Small changes in preparation for Hydrogen-generated KeyedLoadGeneric

Small changes in preparation for Hydrogen-generated KeyedLoadGeneric

R=mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21535

[mvstanton, 2014-05-27 14:49:25]

lgtm, just one question below.

https://codereview.chromium.org/303583002/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/303583002/diff/1/src/hydrogen-instructions.cc...
src/hydrogen-instructions.cc:2907: if (representation().IsExternal()) return
false;
What is the reason for this change out of curiousity?

[danno, 2014-05-27 14:58:25]

https://codereview.chromium.org/303583002/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/303583002/diff/1/src/hydrogen-instructions.cc...
src/hydrogen-instructions.cc:2907: if (representation().IsExternal()) return
false;
On 2014/05/27 14:49:25, mvstanton wrote:
> What is the reason for this change out of curiousity?

This allows us to emit external pointers that are constants, e.g. for the
external buffer that points to the KeyedLoad name cache used be the generic
keyed load stub.

[danno, 2014-05-27 15:15:58]

Committed patchset #1 manually as r21535 (presubmit successful).