cc: Add Scheduler test for SetSwapUsedIncompleteTile

cc: Add Scheduler test for SetSwapUsedIncompleteTile

Add tests whether ScheduledActionShouldUpdateVisibleTiles() is executed
or not when Scheduler::SetSwapUsedIncompleteTile() is called.
Then, checks draw operation in the next deadline.

R=brianderson@chromium.org
BUG=377641
TEST=cc_unittests --gtest_filter=SchedulerTest.ShouldUpdateVisibleTiles

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273157

[simonhong, 2014-05-27 07:48:07]

PTAL!

[brianderson, 2014-05-27 21:15:57]

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
File cc/scheduler/scheduler_unittest.cc (right):

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:45: contain_incomplete_tile_(false) {
swap_contains_incomplete_tile_

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:87: void set_contain_incomplete_tile(bool
contain) {
SetSwapContainsIncompleteTile

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:186: bool contain_incomplete_tile_;
This isn't used by the base class. Can you put it in
SchedulerClientNeedsUpdateVisibleTiles or get just get rid of
SchedulerClientNeedsUpdateVisibleTiles?

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:944:
EXPECT_ACTION("ScheduledActionUpdateVisibleTiles", client, 2, 3);
After this point, can you check that needs_redraw is true and that we will swap
on the next deadline?

[simonhong, 2014-05-27 22:19:24]

On 2014/05/27 21:15:57, brianderson wrote:
>
https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
> File cc/scheduler/scheduler_unittest.cc (right):
> 
>
https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
> cc/scheduler/scheduler_unittest.cc:45: contain_incomplete_tile_(false) {
> swap_contains_incomplete_tile_
> 
>
https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
> cc/scheduler/scheduler_unittest.cc:87: void set_contain_incomplete_tile(bool
> contain) {
> SetSwapContainsIncompleteTile
> 
>
https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
> cc/scheduler/scheduler_unittest.cc:186: bool contain_incomplete_tile_;
> This isn't used by the base class. Can you put it in
> SchedulerClientNeedsUpdateVisibleTiles or get just get rid of
> SchedulerClientNeedsUpdateVisibleTiles?
> 
>
https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
> cc/scheduler/scheduler_unittest.cc:944:
> EXPECT_ACTION("ScheduledActionUpdateVisibleTiles", client, 2, 3);
> After this point, can you check that needs_redraw is true and that we will
swap
> on the next deadline?

I checked that needs_redraw_ is not set to true right after UpdateVisibleTiles()
is called.It is set by LTHI.
Do you mean that let's check whether swap is occurred or not in the next
deadline with calling SetNeedsRedraw() explicitly here?

[brianderson, 2014-05-27 23:44:30]

> Do you mean that let's check whether swap is occurred or not in the next
> deadline with calling SetNeedsRedraw() explicitly here?

I mean *without* calling SetNeedsRedraw explicitly.

[simonhong, 2014-05-28 00:09:35]

To trigger draw, SetRedrawWillHappenIfUpdateVisibleTilesHappens() is called when
ScheduledActionUpdateVisibleTiles() is called.
Does this way looks ok? :)

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
File cc/scheduler/scheduler_unittest.cc (right):

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:45: contain_incomplete_tile_(false) {
On 2014/05/27 21:15:57, brianderson wrote:
> swap_contains_incomplete_tile_

Done.

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:87: void set_contain_incomplete_tile(bool
contain) {
On 2014/05/27 21:15:57, brianderson wrote:
> SetSwapContainsIncompleteTile

Done.

https://codereview.chromium.org/303573002/diff/1/cc/scheduler/scheduler_unitt...
cc/scheduler/scheduler_unittest.cc:186: bool contain_incomplete_tile_;
On 2014/05/27 21:15:57, brianderson wrote:
> This isn't used by the base class. Can you put it in
> SchedulerClientNeedsUpdateVisibleTiles or get just get rid of
> SchedulerClientNeedsUpdateVisibleTiles?

Ah.. yes.
SchedulerClientNeedsUpdateVisibleTiles is not needed.
Removed.

[brianderson, 2014-05-28 00:17:24]

On 2014/05/28 00:09:35, simonhong wrote:
> To trigger draw, SetRedrawWillHappenIfUpdateVisibleTilesHappens() is called
when
> ScheduledActionUpdateVisibleTiles() is called.
> Does this way looks ok? :)

Yes. Thanks for figuring that out, I forgot that the client would be in charge
of requesting the redraw when a new visible tile completes.

lgtm

[simonhong, 2014-05-28 00:23:37]

On 2014/05/28 00:17:24, brianderson wrote:
> On 2014/05/28 00:09:35, simonhong wrote:
> > To trigger draw, SetRedrawWillHappenIfUpdateVisibleTilesHappens() is called
> when
> > ScheduledActionUpdateVisibleTiles() is called.
> > Does this way looks ok? :)
> 
> Yes. Thanks for figuring that out, I forgot that the client would be in charge
> of requesting the redraw when a new visible tile completes.
> 
> lgtm

Thanks for quick review.
I added impl_side check in InitializeOutputSurfaceAndFirstCommit(), too.

[simonhong, 2014-05-28 00:29:03]

The CQ bit was checked by simonhong@chromium.org

[commit-bot: I haz the power, 2014-05-28 00:32:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/simonhong@chromium.org/303573002/60001

[commit-bot: I haz the power, 2014-05-28 04:03:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-28 05:36:21]

Change committed as 273157