Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 303543009: replace config() with colorType() (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

replace config() with colorType() BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14959

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Total comments: 1

Patch Set 4 : fix arm files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -92 lines) Patch
M gm/gm_expectations.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkBlitRow.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 14 chunks +32 lines, -32 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
M src/core/SkBitmapProcState_procs.h View 15 chunks +15 lines, -15 lines 0 comments Download
M src/core/SkBlitMask.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkBlitMask_D32.cpp View 1 2 3 5 chunks +16 lines, -9 lines 0 comments Download
M src/core/SkBlitRow_D16.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkBlitter_ARGB32.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkSpriteBlitter_RGB16.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkBlitMask_opts_arm.cpp View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download
M src/opts/SkBlitMask_opts_none.cpp View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
reed1
6 years, 6 months ago (2014-05-28 20:30:50 UTC) #1
robertphillips
https://codereview.chromium.org/303543009/diff/20001/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/303543009/diff/20001/src/core/SkBitmapProcState.cpp#newcode881 src/core/SkBitmapProcState.cpp:881: 4?
6 years, 6 months ago (2014-05-29 12:13:42 UTC) #2
reed1
https://codereview.chromium.org/303543009/diff/20001/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/303543009/diff/20001/src/core/SkBitmapProcState.cpp#newcode881 src/core/SkBitmapProcState.cpp:881: On 2014/05/29 12:13:42, robertphillips wrote: > 4? Was waffling ...
6 years, 6 months ago (2014-05-29 12:31:22 UTC) #3
reed1
https://codereview.chromium.org/303543009/diff/20001/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/303543009/diff/20001/src/core/SkBitmapProcState.cpp#newcode881 src/core/SkBitmapProcState.cpp:881: On 2014/05/29 12:31:23, reed1 wrote: > On 2014/05/29 12:13:42, ...
6 years, 6 months ago (2014-05-29 12:33:34 UTC) #4
reed1
ptal
6 years, 6 months ago (2014-05-29 13:29:06 UTC) #5
robertphillips
lgtm. Are the GM failures due to Brian's CL?
6 years, 6 months ago (2014-05-29 14:08:24 UTC) #6
robertphillips
https://codereview.chromium.org/303543009/diff/40001/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (right): https://codereview.chromium.org/303543009/diff/40001/src/core/SkBitmapProcState.cpp#newcode169 src/core/SkBitmapProcState.cpp:169: if (NULL == fScaledCacheID) { destWidth ? destHeight ?
6 years, 6 months ago (2014-05-29 14:10:18 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-05-29 15:20:04 UTC) #8
reed1
The CQ bit was unchecked by reed@google.com
6 years, 6 months ago (2014-05-29 15:20:08 UTC) #9
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-05-29 15:20:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/303543009/60001
6 years, 6 months ago (2014-05-29 15:21:28 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 15:57:52 UTC) #12
Message was sent while issue was closed. 
Change committed as 14959

Powered by Google App Engine
This is Rietveld 408576698