Fix a bug in gpu_unittests mock expectations for VAO.

Fix a bug in gpu_unittests mock expectations for VAO.

I notcied this bug while trying to fix the WebGL VAO related regressions
on Linux AMD.

Before the generated ID is not set, so by default it's 0, which
is wrong, because 0 is reserved to unbind instead of bind.

Also, turn on VAO support for majority of tests as the emulated code path
is more isolated and its tests are also more isolated.  I feel it's better
to test with VAO on by default.

BUG=373974
TEST=gpu_unittests
R=vmiura@chromium.org,kbr@chromium.org,piman@chromium.org,jbauman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273123

[Zhenyao Mo, 2014-05-27 18:02:26]

Please review.

[bajones, 2014-05-27 18:10:56]

LGTM

[vmiura, 2014-05-27 18:18:07]

https://codereview.chromium.org/303543005/diff/20001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):

https://codereview.chromium.org/303543005/diff/20001/gpu/command_buffer/servi...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:73:
init.extensions = "GL_OES_vertex_array_object";
Many of the tests override this SetUp().

Could we add a native_vao field to InitState, default (true) and change
GLES2DecoderTestBase::InitDecoderWithCommandLine() to add the extension based on
the flag?

[Ken Russell (switch to Gerrit), 2014-05-27 18:24:31]

LGTM - though I'm not an owner in this directory.

https://codereview.chromium.org/303543005/diff/20001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):

https://codereview.chromium.org/303543005/diff/20001/gpu/command_buffer/servi...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:74:
init.gl_version = "opengl es 2.0";
Is the change of the assumed GL_VERSION in the tests from a desktop GL version
to ES 2.0 risky? Is it going to change the behavior of a lot of tests? Perhaps
not, since almost no test expectations had to be updated.

[Zhenyao Mo, 2014-05-27 21:22:48]

vmiura: please take another look.

https://codereview.chromium.org/303543005/diff/20001/gpu/command_buffer/servi...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):

https://codereview.chromium.org/303543005/diff/20001/gpu/command_buffer/servi...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:73:
init.extensions = "GL_OES_vertex_array_object";
On 2014/05/27 18:18:08, vmiura wrote:
> Many of the tests override this SetUp().
> 
> Could we add a native_vao field to InitState, default (true) and change
> GLES2DecoderTestBase::InitDecoderWithCommandLine() to add the extension based
on
> the flag?

Done.

[vmiura, 2014-05-27 21:41:38]

On 2014/05/27 21:22:48, Zhenyao Mo wrote:
> vmiura: please take another look.
> 
>
https://codereview.chromium.org/303543005/diff/20001/gpu/command_buffer/servi...
> File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):
> 
>
https://codereview.chromium.org/303543005/diff/20001/gpu/command_buffer/servi...
> gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:73:
> init.extensions = "GL_OES_vertex_array_object";
> On 2014/05/27 18:18:08, vmiura wrote:
> > Many of the tests override this SetUp().
> > 
> > Could we add a native_vao field to InitState, default (true) and change
> > GLES2DecoderTestBase::InitDecoderWithCommandLine() to add the extension
based
> on
> > the flag?
> 
> Done.

LGTM, thanks.

[Zhenyao Mo, 2014-05-27 21:48:50]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2014-05-27 21:49:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zmo@chromium.org/303543005/60001

[commit-bot: I haz the power, 2014-05-28 01:05:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-28 02:59:06]

Change committed as 273123