Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: content/renderer/render_view_impl.cc

Issue 303503008: Convert geolocation code to use RenderFrame instead of RenderView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: fix interactive ui test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | ui/views/controls/webview/webview_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
===================================================================
--- content/renderer/render_view_impl.cc (revision 274175)
+++ content/renderer/render_view_impl.cc (working copy)
@@ -683,19 +683,19 @@
// Ensure we start with a valid next_page_id_ from the browser.
DCHECK_GE(next_page_id_, 0);
- RenderFrameImpl* main_render_frame = RenderFrameImpl::Create(
- this, params->main_frame_routing_id);
+ main_render_frame_.reset(RenderFrameImpl::Create(
+ this, params->main_frame_routing_id));
// The main frame WebLocalFrame object is closed by
// RenderFrameImpl::frameDetached().
- WebLocalFrame* web_frame = WebLocalFrame::create(main_render_frame);
- main_render_frame->SetWebFrame(web_frame);
+ WebLocalFrame* web_frame = WebLocalFrame::create(main_render_frame_.get());
+ main_render_frame_->SetWebFrame(web_frame);
if (params->proxy_routing_id != MSG_ROUTING_NONE) {
CHECK(params->swapped_out);
RenderFrameProxy* proxy =
RenderFrameProxy::CreateFrameProxy(params->proxy_routing_id,
params->main_frame_routing_id);
- main_render_frame->set_render_frame_proxy(proxy);
+ main_render_frame_->set_render_frame_proxy(proxy);
}
webwidget_ = WebView::create(this);
@@ -757,7 +757,6 @@
webview()->settings()->setAllowConnectingInsecureWebSocket(
command_line.HasSwitch(switches::kAllowInsecureWebSocketFromHttpsOrigin));
- main_render_frame_.reset(main_render_frame);
webview()->setMainFrame(main_render_frame_->GetWebFrame());
main_render_frame_->Initialize();
@@ -3634,8 +3633,10 @@
}
blink::WebGeolocationClient* RenderViewImpl::geolocationClient() {
- if (!geolocation_dispatcher_)
- geolocation_dispatcher_ = new GeolocationDispatcher(this);
+ if (!geolocation_dispatcher_) {
+ geolocation_dispatcher_ = new GeolocationDispatcher(
+ main_render_frame_.get());
+ }
return geolocation_dispatcher_;
}
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | ui/views/controls/webview/webview_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698