Change directory if the active list item on navigation list is changed.

chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Browser test for basic Chrome OS file manager functionality:
 //  - The file list is updated when a file is added externally to the Downloads
 //    folder.
 //  - Selecting a file and copy-pasting it with the keyboard copies the file.
 //  - Selecting a file and pressing delete deletes it.
 
@@ skipping 883 matching lines @@
     FileManagerBrowserTest,
     ::testing::Values(
         TestParameter(NOT_IN_GUEST_MODE, "executeDefaultTaskOnDrive")));
 
 INSTANTIATE_TEST_CASE_P(
     NavigationList,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE,
                                     "traverseNavigationList")));
 
+// This macro expands prefix before it is concatenated with test_case_name.
+#define WRAPPED_INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator) \

[fukino, 2014/06/05 11:27:38]

MAYBE_FolderShortcuts was not expanded because INSTANTIATE_TEST_CASE_P macro
concatenates prefix(MAYBE_FolderShortcuts) and
test_case_name(FileManagerBrowserTest) first.

This macro works around for this.

[yoshiki, 2014/06/05 15:11:23]

nit: Please write it in the comment. The detailed comment will help a code
reader in near feature.

[fukino, 2014/06/06 02:15:24]

I agree! It wasn't good idea to make the comment one line for tricky code like
this.

I copied comment from following code because the explanation is more precise,
detailed, and general than my review comment.
https://code.google.com/p/chromium/codesearch#chromium/src/net/cert/cert_veri...

+    INSTANTIATE_TEST_CASE_P(prefix, test_case_name, generator)
+
+// This test is too slow to run in debug build. http://crbug.com/327719
+#if !defined(NDEBUG)
+#define MAYBE_FolderShortcuts DISABLED_FolderShortcuts
+#else
+#define MAYBE_FolderShortcuts FolderShortcuts
+#endif
+WRAPPED_INSTANTIATE_TEST_CASE_P(
+    MAYBE_FolderShortcuts,
+    FileManagerBrowserTest,
+    ::testing::Values(
+        TestParameter(NOT_IN_GUEST_MODE, "traverseFolderShortcuts"),
+        TestParameter(NOT_IN_GUEST_MODE, "addRemoveFolderShortcuts")));
+
 INSTANTIATE_TEST_CASE_P(
     TabIndex,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "searchBoxFocus")));
 
 INSTANTIATE_TEST_CASE_P(
     Thumbnails,
     FileManagerBrowserTest,
     ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "thumbnailsDownloads"),
                       TestParameter(IN_GUEST_MODE, "thumbnailsDownloads")));
@@ skipping 222 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(GalleryBrowserTest, OpenSingleImageOnDrive) {
   AddScript("gallery/open_image_files.js");
   set_test_case_name("openSingleImageOnDrive");
   StartTest();
 }
 
 }  // namespace
 }  // namespace file_manager