Issue 3035005: Add private Pepper v2 API to get localized strings.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3035005: Add private Pepper v2 API to get localized strings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by jam

Modified:
4 years ago

Reviewers:
darin (slow to review), brettw, brettw at google

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add private Pepper v2 API to get localized strings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52754

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -4 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_module.cc	View	1	3 chunks	+4 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_private.h	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/pepper_private.cc	View		1 chunk	+38 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/ppb_private.h	View		1 chunk	+21 lines, -0 lines	2 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_strings.grd	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

4 years, 10 months ago (2010-07-17 02:51:19 UTC) #3

http://codereview.chromium.org/3035005/diff/8001/9005
File webkit/glue/plugins/ppb_private.h (right):

http://codereview.chromium.org/3035005/diff/8001/9005#newcode12
webkit/glue/plugins/ppb_private.h:12: typedef enum _ppb_ResourceString {
_pp_

http://codereview.chromium.org/3035005/diff/8001/9005#newcode13
webkit/glue/plugins/ppb_private.h:13: PPB_RESOURCE_STRING_PDF_GET_PASSWORD = 0,
PP_RESOURCESTRING_PDFGETPASSWORD

Expand Messages | Collapse Messages