Chromium Code Reviews
Help | Chromium Project | Sign in
(52)

Issue 3035005: Add private Pepper v2 API to get localized strings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by jam
Modified:
4 years ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add private Pepper v2 API to get localized strings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52754

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/glue/plugins/pepper_plugin_module.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
A webkit/glue/plugins/pepper_private.h View 1 chunk +23 lines, -0 lines 0 comments Download
A webkit/glue/plugins/pepper_private.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A webkit/glue/plugins/ppb_private.h View 1 chunk +21 lines, -0 lines 2 comments Download
M webkit/glue/webkit_glue.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
M webkit/glue/webkit_strings.grd View 1 1 chunk +4 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
jam
Brett/Darin: whoever can get to it first :)
4 years, 10 months ago (2010-07-16 21:27:47 UTC) #1
brettw at google
LGTM
4 years, 10 months ago (2010-07-16 21:36:54 UTC) #2
darin (slow to review)
4 years, 10 months ago (2010-07-17 02:51:19 UTC) #3
http://codereview.chromium.org/3035005/diff/8001/9005
File webkit/glue/plugins/ppb_private.h (right):

http://codereview.chromium.org/3035005/diff/8001/9005#newcode12
webkit/glue/plugins/ppb_private.h:12: typedef enum _ppb_ResourceString {
_pp_

http://codereview.chromium.org/3035005/diff/8001/9005#newcode13
webkit/glue/plugins/ppb_private.h:13: PPB_RESOURCE_STRING_PDF_GET_PASSWORD = 0,
PP_RESOURCESTRING_PDFGETPASSWORD
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be