Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 303483006: Fix a data URL generation code in DeveloperPrivateAPI (Closed)

Created:
6 years, 7 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 7 months ago
Reviewers:
dvh
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fix a data URL generation code in DeveloperPrivateAPI "image" is specified as a MIME type but is invalid. We should just omit the MIME type parameter. BUG=377409 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 7 months ago (2014-05-26 13:40:26 UTC) #1
dvh
On 2014/05/26 13:40:26, tyoshino wrote: lgtm.
6 years, 7 months ago (2014-05-27 17:17:39 UTC) #2
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 7 months ago (2014-05-27 19:13:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/303483006/1
6 years, 7 months ago (2014-05-27 19:14:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 23:46:27 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 02:49:42 UTC) #6
Message was sent while issue was closed.
Change committed as 273118

Powered by Google App Engine
This is Rietveld 408576698