Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 303483005: [SVG2] Make ownerSVGElement and viewportElement nullable. (Closed)

Created:
6 years, 6 months ago by Erik Dahlström (inactive)
Modified:
6 years, 6 months ago
Reviewers:
fs
CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/svg/SVGElement.idl View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
Erik Dahlström (inactive)
6 years, 6 months ago (2014-05-26 12:50:37 UTC) #1
fs
LGTM (This only codifies current behavior after all - i.e. there should be no change ...
6 years, 6 months ago (2014-05-26 13:05:42 UTC) #2
Erik Dahlström (inactive)
https://codereview.chromium.org/303483005/diff/1/Source/core/svg/SVGElement.idl File Source/core/svg/SVGElement.idl (right): https://codereview.chromium.org/303483005/diff/1/Source/core/svg/SVGElement.idl#newcode28 Source/core/svg/SVGElement.idl:28: [TypeChecking=Interface|Nullable] readonly attribute SVGElement? viewportElement; On 2014/05/26 13:05:42, fs ...
6 years, 6 months ago (2014-05-26 13:13:34 UTC) #3
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 6 months ago (2014-05-26 13:13:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/303483005/1
6 years, 6 months ago (2014-05-26 13:14:06 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-26 13:46:04 UTC) #6
Message was sent while issue was closed.
Change committed as 174809

Powered by Google App Engine
This is Rietveld 408576698