Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 303473009: Fix setting shape-outside: none (Closed)

Created:
6 years, 7 months ago by alancutter (OOO until 2018)
Modified:
6 years, 6 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, darktears, Steve Block, Eric Willigers
Visibility:
Public.

Description

Fix setting shape-outside: none The CSS parser and CSSComputedStyleDeclaration use the none keyword for the shape-outside property. CSSAnimatableValueFactory and StyleBuilderFunctions treat the same shape value as the auto keyword. The effect of this is that the none shape value is never applied. According to the spec we should be using the none keyword. http://dev.w3.org/csswg/css-shapes-1/#shape-outside-property BUG=378071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
A LayoutTests/fast/shapes/parsing/parsing-shape-outside-none.html View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
alancutter (OOO until 2018)
6 years, 7 months ago (2014-05-28 00:26:38 UTC) #1
Timothy Loh
On 2014/05/28 00:26:38, alancutter wrote: So the parser lets through "none" but handle "auto" instead? ...
6 years, 7 months ago (2014-05-28 00:33:14 UTC) #2
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 7 months ago (2014-05-28 00:41:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/303473009/1
6 years, 7 months ago (2014-05-28 00:41:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 7 months ago (2014-05-28 02:11:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-28 02:11:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/18134)
6 years, 7 months ago (2014-05-28 02:11:41 UTC) #7
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 6 months ago (2014-05-28 05:25:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/303473009/1
6 years, 6 months ago (2014-05-28 05:25:30 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-05-28 05:27:10 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 05:27:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/18134)
6 years, 6 months ago (2014-05-28 05:27:46 UTC) #12
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 6 months ago (2014-05-28 06:10:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/303473009/1
6 years, 6 months ago (2014-05-28 06:11:00 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 06:11:45 UTC) #15
Message was sent while issue was closed.
Change committed as 174936

Powered by Google App Engine
This is Rietveld 408576698