Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 303463009: Remove SkThread.h from public API. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
mtklein, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove SkThread.h from public API. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14926

Patch Set 1 #

Patch Set 2 : rest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -125 lines) Patch
M include/core/SkInstCnt.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkOnce.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkRefCnt.h View 1 chunk +2 lines, -1 line 0 comments Download
D include/core/SkThread.h View 1 chunk +0 lines, -117 lines 0 comments Download
M include/core/SkWeakRefCnt.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrBackendEffectFactory.h View 1 1 chunk +2 lines, -1 line 0 comments Download
A + src/core/SkThread.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/views/SkEvent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkEventSink.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/views/SkOSMenu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
6 years, 6 months ago (2014-05-28 18:53:03 UTC) #1
reed1
as good as Democracy... lgtm
6 years, 6 months ago (2014-05-28 18:55:07 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-05-28 18:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/303463009/1
6 years, 6 months ago (2014-05-28 18:56:09 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-05-28 19:07:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/303463009/20001
6 years, 6 months ago (2014-05-28 19:07:44 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 19:25:03 UTC) #7
Message was sent while issue was closed.
Change committed as 14926

Powered by Google App Engine
This is Rietveld 408576698