Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 303463005: Extract build configuration into a separate header and move it to the base lib (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Extract build configuration into a separate header and move it to the base lib With this, change, atomicops, once, and lazy instance are no longer dependant on v8 core. I'll move them in a follow-up change to the libbase as well. BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -153 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/atomicops.h View 1 chunk +1 line, -1 line 0 comments Download
M src/atomicops_internals_x86_msvc.h View 1 chunk +1 line, -1 line 0 comments Download
A src/base/build_config.h View 1 chunk +120 lines, -0 lines 0 comments Download
M src/base/macros.h View 1 chunk +34 lines, -0 lines 0 comments Download
M src/checks.h View 1 chunk +0 lines, -27 lines 0 comments Download
M src/flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/globals.h View 5 chunks +1 line, -116 lines 0 comments Download
M src/lazy-instance.h View 1 chunk +1 line, -1 line 0 comments Download
M src/once.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/platform/mutex.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-05-27 15:20:00 UTC) #1
Jakob Kummerow
lgtm
6 years, 6 months ago (2014-05-28 07:55:10 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-05-28 08:07:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698