binary_size: Easier-to-read output

tools/binary_size/run_binary_size_analysis.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generate a spatial analysis against an arbitrary library.
 
 To use, build the 'binary_size_tool' target. Then run this tool, passing
 in the location of the library to be analyzed along with any other options
 you desire.
@@ skipping 70 matching lines @@
         largest_list_len = child_largest_list_len
       child_list.append(child)
     node['children'] = child_list
 
   return largest_list_len
 
 
 def MakeCompactTree(symbols):
   result = {'n': '/', 'children': {}, 'k': 'p', 'maxDepth': 0}
   seen_symbol_with_path = False
+  cwd = os.path.abspath(os.getcwd())
   for symbol_name, symbol_type, symbol_size, file_path in symbols:
 
     if 'vtable for ' in symbol_name:
       symbol_type = '@' # hack to categorize these separately
     # Take path like '/foo/bar/baz', convert to ['foo', 'bar', 'baz']
-    if file_path:
-      file_path = os.path.normpath(file_path)
+    if file_path and file_path != "??":

[Primiano Tucci (use gerrit), 2014/05/27 09:06:26]

Please be consistent with quotes (we tend to use single quotes pretty much
everywhere in chromium code)

+      file_path = os.path.abspath(file_path)

[Primiano Tucci (use gerrit), 2014/05/27 09:06:26]

Lines 98-100 look like re-implementing python
os.path.relpath ;)

* https://docs.python.org/2/library/os.path.html

+      if file_path.startswith(cwd + os.sep):
+        file_path = file_path[len(cwd):]
       seen_symbol_with_path = True
     else:
       file_path = '(No Path)'
 
     if file_path.startswith('/'):
       file_path = file_path[1:]
     path_parts = file_path.split('/')
 
     # Find pre-existing node in tree, or update if it already exists
     node = result
@@ skipping 319 matching lines @@
   progress = Progress()
   def map_address_symbol(symbol, addr):
     progress.count += 1
     if addr in address_symbol:
       # 'Collision between %s and %s.' % (str(symbol.name),
       #                                   str(address_symbol[addr].name))
       progress.collisions += 1
     else:
       address_symbol[addr] = symbol
 
+    progress_output()
+
+  def progress_output():

[Primiano Tucci (use gerrit), 2014/05/27 09:06:26]

Hmm what is the rationale of defining and calling a nested function in the
middle of another function (note that you have still code referring to the outer
RunElfSymbolizer) after the inner function?
It doesn't look easier to read, it is the exact same code as before, with two
extra line. It doesn't either look being reused anywhere.

     progress_chunk = 100
     if progress.count % progress_chunk == 0:
       time_now = time.time()
       time_spent = time_now - progress.time_last_output
       if time_spent > 1.0:
         # Only output at most once per second.
         progress.time_last_output = time_now
         chunk_size = progress.count - progress.count_last_output
         progress.count_last_output = progress.count
         if time_spent > 0:
@@ skipping 234 matching lines @@
     print('Copying index.html')
     shutil.copy(os.path.join(template_src, 'index.html'), opts.destdir)
     shutil.copy(os.path.join(template_src, 'D3SymbolTreeMap.js'), opts.destdir)
 
   if opts.verbose:
     print 'Report saved to ' + opts.destdir + '/index.html'
 
 
 if __name__ == '__main__':
   sys.exit(main())