Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 303443011: Retry requests on reused sockets when receiving 408 responses. (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke
Visibility:
Public.

Description

Retry requests on reused sockets when receiving 408 responses. 408s indicate a socket was left idle for too long before sending a request. It's possible these errors are being surfaced to users more often than previously due to https://codereview.chromium.org/169643006, for servers that very aggressively time out never-used sockets. BUG=377581 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274760

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M net/base/net_log_event_type_list.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/http/http_network_transaction.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
Will: Know you're travelling. Wasn't sure if I should send this to you or not.
6 years, 6 months ago (2014-06-03 17:39:30 UTC) #1
willchan no longer on Chromium
LGTM https://codereview.chromium.org/303443011/diff/1/net/http/http_network_transaction_unittest.cc File net/http/http_network_transaction_unittest.cc (right): https://codereview.chromium.org/303443011/diff/1/net/http/http_network_transaction_unittest.cc#newcode1450 net/http/http_network_transaction_unittest.cc:1450: KeepAliveConnectionResendRequestTest(NULL, &read_failure); Indentation is off
6 years, 6 months ago (2014-06-03 21:01:02 UTC) #2
mmenke
https://codereview.chromium.org/303443011/diff/1/net/http/http_network_transaction_unittest.cc File net/http/http_network_transaction_unittest.cc (right): https://codereview.chromium.org/303443011/diff/1/net/http/http_network_transaction_unittest.cc#newcode1450 net/http/http_network_transaction_unittest.cc:1450: KeepAliveConnectionResendRequestTest(NULL, &read_failure); On 2014/06/03 21:01:02, willchan (traveling 5.23-6.27) wrote: ...
6 years, 6 months ago (2014-06-03 22:45:58 UTC) #3
mmenke
The CQ bit was checked by mmenke@chromium.org
6 years, 6 months ago (2014-06-03 22:46:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/303443011/20001
6 years, 6 months ago (2014-06-03 22:48:16 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 02:10:09 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 10:55:59 UTC) #7
Message was sent while issue was closed.
Change committed as 274760

Powered by Google App Engine
This is Rietveld 408576698