Send TextEvent for keyboard event generated by software keyboard.

Send TextEvent for keyboard event generated by software keyboard.

Android keyboard generates key press and key release events for latin
keyboard. The client was sending them as KeyEvent, as result the host
was not injecting correct characters when remote keyboard layout is
not Qwerty. Now client sends TextEvent for events that come from
software keyboard.

BUG=364276
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275547

[Lambros, 2014-05-28 22:32:28]

lgtm with comments

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:190: // This
ensures that on-screen keyboard always inject input that
s/inject/injects

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:202: // want to
send it as KeyEvent.
What about Backspace - will that work as expected?

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:211: int[]
codePoints = new int[1];
This could be: int[] codePoints = { unicode }
but don't need it anyway :)

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:213:
JniInterface.sendTextEvent(new String(codePoints, 0, 1));
You can convert to string like this:
String.valueOf((char) unicode)
or
Character.toString((char) unicode)

[Sergey Ulanov, 2014-06-06 18:43:46]

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
File remoting/android/java/src/org/chromium/chromoting/Desktop.java (right):

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:190: // This
ensures that on-screen keyboard always inject input that
On 2014/05/28 22:32:28, Lambros wrote:
> s/inject/injects

Done.

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:202: // want to
send it as KeyEvent.
On 2014/05/28 22:32:28, Lambros wrote:
> What about Backspace - will that work as expected?

Yes. getCharacter() is not set for Backspace.

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:211: int[]
codePoints = new int[1];
On 2014/05/28 22:32:28, Lambros wrote:
> This could be: int[] codePoints = { unicode }

Done.

> but don't need it anyway :)

I think we do need it. See my comment below.

https://codereview.chromium.org/303443004/diff/40001/remoting/android/java/sr...
remoting/android/java/src/org/chromium/chromoting/Desktop.java:213:
JniInterface.sendTextEvent(new String(codePoints, 0, 1));
On 2014/05/28 22:32:28, Lambros wrote:
> You can convert to string like this:
> String.valueOf((char) unicode)
> or
> Character.toString((char) unicode)

In Java char is 16 bits and can encode only plane 0. I.e. this won't work for
surrogates.

[Sergey Ulanov, 2014-06-06 18:50:43]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-06-06 18:53:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sergeyu@chromium.org/303443004/80001

[commit-bot: I haz the power, 2014-06-06 22:37:34]

Change committed as 275547