Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 303423004: Assert that all Blink cache policies are covered (Closed)

Created:
6 years, 6 months ago by clamy
Modified:
6 years, 6 months ago
Reviewers:
jam, ppi
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Assert that all Blink cache policies are covered This a preparatory CL to land https://chromiumcodereview.appspot.com/309693002/ which introduces new values for Blink cache policies. BUG=376025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274188

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
clamy
PTAL: this is the first patch in a series of 3 to introduce a new ...
6 years, 6 months ago (2014-05-30 18:18:42 UTC) #1
ppi
Good idea! I'd make the title more descriptive, like: "Assert that all Blink cache policies ...
6 years, 6 months ago (2014-06-01 23:04:28 UTC) #2
clamy
@jam: PTAL. This is the first patch in a series of 5 aiming at removing ...
6 years, 6 months ago (2014-06-02 05:30:50 UTC) #3
jam
lgtm
6 years, 6 months ago (2014-06-02 06:49:53 UTC) #4
clamy
The CQ bit was checked by clamy@chromium.org
6 years, 6 months ago (2014-06-02 06:50:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clamy@chromium.org/303423004/1
6 years, 6 months ago (2014-06-02 06:50:59 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 08:18:41 UTC) #7
Message was sent while issue was closed.
Change committed as 274188

Powered by Google App Engine
This is Rietveld 408576698