Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 303423002: Browser Plugin: Remove Zoom (Closed)

Created:
6 years, 6 months ago by Fady Samuel
Modified:
6 years, 6 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Browser Plugin: Remove Zoom With the zoom refactor in flight: https://codereview.chromium.org/287093002/, zoom plumbing for BrowserPlugin in the content layer is now entirely dead code. We need to revisit zoom in the chrome layer for <webview> so that the embedder's zoom is propagated to the guests. This will be done at a later time when we need to get <webview> in WebUI working again. BUG=330264 TBR=jam@chromium.org for trivial browser_plugin_guest_delegate.h code deletion. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273959

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -46 lines) Patch
M chrome/browser/guest_view/web_view/web_view_guest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/guest_view/web_view/web_view_guest.cc View 1 2 chunks +13 lines, -13 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/browser_plugin_guest_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Fady Samuel
6 years, 6 months ago (2014-05-30 14:08:09 UTC) #1
lazyboy
lgtm
6 years, 6 months ago (2014-05-30 15:08:35 UTC) #2
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-05-30 15:08:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/303423002/1
6 years, 6 months ago (2014-05-30 15:10:26 UTC) #4
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 6 months ago (2014-05-30 17:54:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/303423002/20001
6 years, 6 months ago (2014-05-30 17:57:23 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 00:39:06 UTC) #7
Message was sent while issue was closed.
Change committed as 273959

Powered by Google App Engine
This is Rietveld 408576698