DescriptionRevert of Avoid redundant initialization of GraphicsContextState. (https://codereview.chromium.org/303613002/)
Reason for revert:
This change is the cause of a
leak in PhishingDOMFeatureExtractorTest.ScriptAndImageFeatures
under LSAN. See
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2642/steps/browser_tests/logs/ScriptAndImageFeatures
Original issue's description:
> Avoid redundant initialization of GraphicsContextState.
>
> When creating a new GraphicsContextState the constructor initializes the state
> with various default values. In GraphicsContext::realizePaintState we immediately
> overwrite these values after creation. This patch adds a copy constructor to
> GraphicsContextState to avoid that.
>
> Even though this seems like a clear win, the benefits are not visible when
> profiling. Looks like the overhead of the redundant initialization is
> not very large. Still seems worth fixing though.
>
> BUG=377687
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174985
TBR=schenney@chromium.org,fmalita@chromium.org,dominikg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=377687
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175159
Patch Set 1 #
Created: 6 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|