Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 303403006: Revert of Avoid redundant initialization of GraphicsContextState. (Closed)

Created:
6 years, 6 months ago by Julien - ping for review
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis, picksi1, Sami
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Avoid redundant initialization of GraphicsContextState. (https://codereview.chromium.org/303613002/) Reason for revert: This change is the cause of a leak in PhishingDOMFeatureExtractorTest.ScriptAndImageFeatures under LSAN. See http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2642/steps/browser_tests/logs/ScriptAndImageFeatures Original issue's description: > Avoid redundant initialization of GraphicsContextState. > > When creating a new GraphicsContextState the constructor initializes the state > with various default values. In GraphicsContext::realizePaintState we immediately > overwrite these values after creation. This patch adds a copy constructor to > GraphicsContextState to avoid that. > > Even though this seems like a clear win, the benefits are not visible when > profiling. Looks like the overhead of the redundant initialization is > not very large. Still seems worth fixing though. > > BUG=377687 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174985 TBR=schenney@chromium.org,fmalita@chromium.org,dominikg@chromium.org NOTREECHECKS=true NOTRY=true BUG=377687 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -40 lines) Patch
M Source/platform/graphics/GraphicsContext.h View 1 chunk +5 lines, -8 lines 0 comments Download
M Source/platform/graphics/GraphicsContextState.h View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/platform/graphics/GraphicsContextState.cpp View 1 chunk +21 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
Created Revert of Avoid redundant initialization of GraphicsContextState.
6 years, 6 months ago (2014-05-30 22:15:24 UTC) #1
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 6 months ago (2014-05-30 22:21:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/303403006/1
6 years, 6 months ago (2014-05-30 22:22:52 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:23:47 UTC) #4
Message was sent while issue was closed.
Change committed as 175159

Powered by Google App Engine
This is Rietveld 408576698