Issue 303393003: Clear g_created_policy_service at BrowserPolicyConnector::Shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303393003: Clear g_created_policy_service at BrowserPolicyConnector::Shutdown. (Closed)

Created:
6 years, 6 months ago by Joao da Silva

Modified:
6 years, 6 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clear g_created_policy_service at BrowserPolicyConnector::Shutdown. This allows other tests in the same suite to call SetPolicyProviderForTesting. TBR=pastarmovj@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274148

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	components/policy/core/browser/browser_policy_connector.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Committed patchset #1 manually as r274148 (presubmit successful).

6 years, 6 months ago (2014-06-01 21:58:08 UTC) #2

Joao da Silva

FYI here's a sample failure: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/37653

6 years, 6 months ago (2014-06-01 21:58:29 UTC) #3

Joao da Silva

6 years, 6 months ago (2014-06-02 09:35:23 UTC) #4

And the fix worked:

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28v...

Somehow dcommit didn't close this issue, going to close manually now.

Expand Messages | Collapse Messages