Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 303373003: Add an OR operator overload for SaveFlags to avoid extra static casts. (Closed)

Created:
6 years, 6 months ago by djsollen
Modified:
6 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add an OR operator overload for SaveFlags to avoid extra static casts. Committed: http://code.google.com/p/skia/source/detail?r=15005

Patch Set 1 #

Total comments: 1

Patch Set 2 : or equals overload too #

Patch Set 3 : fix nit #

Patch Set 4 : fix line spacing #

Patch Set 5 : fix incompetence error #

Patch Set 6 : spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M include/core/SkCanvas.h View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMatrixClipStateMgr.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
djsollen
6 years, 6 months ago (2014-05-30 18:54:34 UTC) #1
reed1
lgtm + nit https://codereview.chromium.org/303373003/diff/1/src/core/SkMatrixClipStateMgr.cpp File src/core/SkMatrixClipStateMgr.cpp (right): https://codereview.chromium.org/303373003/diff/1/src/core/SkMatrixClipStateMgr.cpp#newcode175 src/core/SkMatrixClipStateMgr.cpp:175: fPicRecord->recordSaveLayer(bounds, paint, flags| SkCanvas::kMatrixClip_SaveFlag); nit: space ...
6 years, 6 months ago (2014-05-30 18:58:43 UTC) #2
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 6 months ago (2014-05-30 19:05:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/303373003/60001
6 years, 6 months ago (2014-05-30 19:06:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 19:12:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 19:17:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.chromium (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/2604)
6 years, 6 months ago (2014-05-30 19:17:42 UTC) #7
djsollen
The CQ bit was checked by djsollen@google.com
6 years, 6 months ago (2014-05-30 20:28:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/303373003/2
6 years, 6 months ago (2014-05-30 20:29:17 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 20:41:22 UTC) #10
Message was sent while issue was closed.
Change committed as 15005

Powered by Google App Engine
This is Rietveld 408576698