Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 303363002: Fix toV8 and ExceptionState with empty context. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Fix toV8 and ExceptionState with empty context. BUG=369451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/bindings/v8/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tasak
Would you review this CL?
6 years, 6 months ago (2014-05-30 05:00:22 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-05-30 05:04:28 UTC) #2
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-05-30 06:35:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/303363002/1
6 years, 6 months ago (2014-05-30 06:38:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 09:45:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 10:16:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9583)
6 years, 6 months ago (2014-05-30 10:16:11 UTC) #7
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-05-30 10:43:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/303363002/1
6 years, 6 months ago (2014-05-30 10:43:30 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 13:00:51 UTC) #10
Message was sent while issue was closed.
Change committed as 175120

Powered by Google App Engine
This is Rietveld 408576698