Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 303313002: Pepper: Move more stuff to content_browsertests. (Closed)

Created:
6 years, 6 months ago by teravest
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Pepper: Move more stuff to content_browsertests. This moves additional tests to content_browsertests. I keep these migrations relatively small so I don't have to debug much if something fails. Additionally, this change adds test coverage for NaCl for MessageLoop testing, and restores testing for MessageLoop_Post. BUG=371873 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273974

Patch Set 1 : build fix #

Patch Set 2 : Move some tests back #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -45 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 2 chunks +5 lines, -28 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M content/test/ppapi/ppapi_browsertest.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M content/test/ppapi/ppapi_test.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/ppapi/ppapi_test.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
teravest
6 years, 6 months ago (2014-05-30 16:55:00 UTC) #1
dmichael (off chromium)
Looks like some of the moved tests are failing
6 years, 6 months ago (2014-05-30 18:31:54 UTC) #2
teravest
Moved the failing tests back to browser_tests, and added comments. On Fri, May 30, 2014 ...
6 years, 6 months ago (2014-05-30 19:58:30 UTC) #3
dmichael (off chromium)
lgtm
6 years, 6 months ago (2014-05-30 20:10:08 UTC) #4
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 6 months ago (2014-05-30 20:10:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/303313002/40001
6 years, 6 months ago (2014-05-30 20:13:51 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 01:12:57 UTC) #7
Message was sent while issue was closed.
Change committed as 273974

Powered by Google App Engine
This is Rietveld 408576698