Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: runtime/vm/flow_graph_builder.cc

Issue 303303002: Address TODOs and remove obsolete ones. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_builder.h" 5 #include "vm/flow_graph_builder.h"
6 6
7 #include "lib/invocation_mirror.h" 7 #include "lib/invocation_mirror.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/class_finalizer.h" 10 #include "vm/class_finalizer.h"
(...skipping 3757 matching lines...) Expand 10 before | Expand all | Expand 10 after
3768 3768
3769 3769
3770 StaticCallInstr* EffectGraphVisitor::BuildThrowNoSuchMethodError( 3770 StaticCallInstr* EffectGraphVisitor::BuildThrowNoSuchMethodError(
3771 intptr_t token_pos, 3771 intptr_t token_pos,
3772 const Class& function_class, 3772 const Class& function_class,
3773 const String& function_name, 3773 const String& function_name,
3774 ArgumentListNode* function_arguments, 3774 ArgumentListNode* function_arguments,
3775 int invocation_type) { 3775 int invocation_type) {
3776 ZoneGrowableArray<PushArgumentInstr*>* arguments = 3776 ZoneGrowableArray<PushArgumentInstr*>* arguments =
3777 new ZoneGrowableArray<PushArgumentInstr*>(); 3777 new ZoneGrowableArray<PushArgumentInstr*>();
3778 // Object receiver. 3778 // Object receiver, actually a class literal of the unresolved method's owner.
3779 // TODO(regis): For now, we pass a class literal of the unresolved
3780 // method's owner, but this is not specified and will probably change.
3781 Type& type = Type::ZoneHandle( 3779 Type& type = Type::ZoneHandle(
3782 I, 3780 I,
3783 Type::New(function_class, 3781 Type::New(function_class,
3784 TypeArguments::Handle(I, TypeArguments::null()), 3782 TypeArguments::Handle(I, TypeArguments::null()),
3785 token_pos, 3783 token_pos,
3786 Heap::kOld)); 3784 Heap::kOld));
3787 type ^= ClassFinalizer::FinalizeType( 3785 type ^= ClassFinalizer::FinalizeType(
3788 function_class, type, ClassFinalizer::kCanonicalize); 3786 function_class, type, ClassFinalizer::kCanonicalize);
3789 Value* receiver_value = Bind(new ConstantInstr(type)); 3787 Value* receiver_value = Bind(new ConstantInstr(type));
3790 arguments->Add(PushArgument(receiver_value)); 3788 arguments->Add(PushArgument(receiver_value));
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
3987 LanguageError::kBailout, 3985 LanguageError::kBailout,
3988 Heap::kNew, 3986 Heap::kNew,
3989 "FlowGraphBuilder Bailout: %s %s", 3987 "FlowGraphBuilder Bailout: %s %s",
3990 String::Handle(I, function.name()).ToCString(), 3988 String::Handle(I, function.name()).ToCString(),
3991 reason)); 3989 reason));
3992 I->long_jump_base()->Jump(1, error); 3990 I->long_jump_base()->Jump(1, error);
3993 UNREACHABLE(); 3991 UNREACHABLE();
3994 } 3992 }
3995 3993
3996 } // namespace dart 3994 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/ast_printer.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698