Issue 3033004: Revert 52600 - renderer_host: Remove CanBlur method....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3033004: Revert 52600 - renderer_host: Remove CanBlur method.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by tfarina

Modified:
4 years ago

Reviewers:
tyoshino, tfarina

CC:
chromium-reviews, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 52600 - renderer_host: Remove CanBlur method. This method was not implemented and always returns true. (Note: this was a TODO for brettw). BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org>; Review URL: http://codereview.chromium.org/2870050 TBR=tfarina@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52601

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -2 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_delegate.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Trybot results:

Total messages: 2 (0 generated)

On 2010/07/16 03:09:03, tfarina wrote:
> 

LGTM