Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 303293004: Android: Remove WindowAndroidObserver::OnWillDestroyWindow() (Closed)

Created:
6 years, 6 months ago by no sievers
Modified:
6 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, powei
Visibility:
Public.

Description

Android: Remove WindowAndroidObserver::OnWillDestroyWindow() This workaround is not needed anymore. The WindowAndroid should now outlive all WebContents. This was also not consistent since there are still many other call sites in the code that assume WindowAndroid is always valid (see ContentViewCoreImpl). BUG=324341 TBR=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/base/android/window_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/android/window_android_observer.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
no sievers
ptal
6 years, 6 months ago (2014-05-30 18:50:08 UTC) #1
David Trainor- moved to gerrit
lgtm
6 years, 6 months ago (2014-05-30 18:51:31 UTC) #2
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 6 months ago (2014-05-30 21:04:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/303293004/1
6 years, 6 months ago (2014-05-30 21:06:45 UTC) #4
no sievers
The CQ bit was unchecked by sievers@chromium.org
6 years, 6 months ago (2014-05-31 00:52:27 UTC) #5
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 6 months ago (2014-05-31 00:53:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/303293004/1
6 years, 6 months ago (2014-05-31 00:54:17 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 01:56:29 UTC) #8
Message was sent while issue was closed. 
Change committed as 273989

Powered by Google App Engine
This is Rietveld 408576698