gn fixes for ui/gl and mac

gn fixes for ui/gl and mac

With this the ui/gl target compiles on mac and fails to link with some skia
thingy.

R=brettw@chromium.org
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274110

[jamesr, 2014-05-31 00:44:51]

We'll need more in third_party/mesa to actual build the library when we need it
but this gets the include paths right at least.

https://codereview.chromium.org/303273009/diff/20001/third_party/mesa/BUILD.gn
File third_party/mesa/BUILD.gn (right):

https://codereview.chromium.org/303273009/diff/20001/third_party/mesa/BUILD.g...
third_party/mesa/BUILD.gn:7: config("mesa_headers_config") {
can i get away with just a target? how do i fwd if i do this?

[brettw, 2014-05-31 04:11:28]

LGTM either way

https://codereview.chromium.org/303273009/diff/20001/third_party/mesa/BUILD.gn
File third_party/mesa/BUILD.gn (right):

https://codereview.chromium.org/303273009/diff/20001/third_party/mesa/BUILD.g...
third_party/mesa/BUILD.gn:7: config("mesa_headers_config") {
On 2014/05/31 00:44:52, jamesr wrote:
> can i get away with just a target? how do i fwd if i do this?

You need the config to forward. You can get away with only the config and no
target if you want to have people do

configs += [ "//third_party/mesa:mesa_headers_config" ]

instead of doing the deps thing.

[brettw, 2014-05-31 04:11:56]

BTW I have some X-platform fixes for Skia linking that will probably be relevant
here.

[tfarina, 2014-05-31 22:35:56]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-31 22:37:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/303273009/20001

[tfarina, 2014-05-31 22:38:13]

Thanks James.

Looks like I need the GPU and gl fixes in my ui/aura patch.

I pushed this to CQ.

[brettw, 2014-05-31 22:54:49]

My Skia fixes went in last night so there is more hope of linking on Mac.

[tfarina, 2014-05-31 23:24:17]

These are the moments were I wish they hadn't remove the feature of being able
to upload patch sets to others' patches. Sigh! :/

Copying Jason, for my above complain :-/

https://codereview.chromium.org/303273009/diff/20001/third_party/mesa/BUILD.gn
File third_party/mesa/BUILD.gn (right):

https://codereview.chromium.org/303273009/diff/20001/third_party/mesa/BUILD.g...
third_party/mesa/BUILD.gn:10: defines += [ "MESA_EGL_NO_X11_HEADERS" ]
Linux GN bot is complaining about this:

ERROR at //third_party/mesa/BUILD.gn:10:5: Undefined variable for +=.
    defines += [ "MESA_EGL_NO_X11_HEADERS" ]
    ^------
I don't have something with this name in scope now.

I think the solution is to have it as:

defines = [ .... ] 

since you don't have a previous "defines" in this scope to have it as +=.

[jamesr, 2014-06-01 00:58:44]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-06-01 00:58:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/303273009/30001

[jamesr, 2014-06-01 00:59:11]

Thanks Thiago - let's see if that does the trick (still works for me locally,
guessing it depends on the context in which the target is used whether there's
already a defines = or not?)

[chromium-reviews, 2014-06-01 03:51:16]

On Sat, May 31, 2014 at 4:24 PM, <tfarina@chromium.org> wrote:

> These are the moments were I wish they hadn't remove the feature of being
> able
> to upload patch sets to others' patches. Sigh! :/
>
> Copying Jason, for my above complain :-/
>

I hear you.  This CL seems to have been worked through quickly anyway, but
I agree that sometimes it would be even faster if the reviewer could just
make a small change immediately.

I do hope to get the chance to implement new features like that (or bring
back the old collaborators feature but make it more secure) in the future,
but for now I am still working on making Rietveld more reliable and
maintainable.  I hope to turn the corner and start considering
high-priority enhancements in the coming months.

Thanks,
jason!

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-06-01 12:17:02]

Change committed as 274110