Issue 303263012: stop using brackets within skimage output filenames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 303263012: stop using brackets within skimage output filenames (Closed)

Created:
6 years, 6 months ago by epoger

Modified:
6 years, 6 months ago

Reviewers:
scroggo

CC:
skia-review_googlegroups.com, borenet

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

stop using brackets within skimage output filenames BUG=skia:2634 Committed: https://skia.googlesource.com/skia/+/f07892413cd2359549dc187f1d10bc48d7d263ba

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/skimage_main.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/303263012/1

6 years, 6 months ago (2014-06-02 20:29:54 UTC) #4

commit-bot: I haz the power

Change committed as f07892413cd2359549dc187f1d10bc48d7d263ba

6 years, 6 months ago (2014-06-02 20:35:25 UTC) #5

epoger

6 years, 6 months ago (2014-06-02 20:45:43 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/314443002/ by epoger@google.com.

The reason for reverting is: Broke
http://108.170.220.120:10117/builders/Test-ChromeOS-Link-HD4000-x86_64-Releas...
:

[13:38:43.401942] /bin/sh: 1: Syntax error: "(" unexpected
[13:38:43.902632] Command
/home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/scripts/slave/../../third_party/gsutil/gsutil
cp -a private
/home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/slave/Test-ChromeOS-Link-HD4000-x86_64-Release/build/skia/out/Release/skimage_out/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png
gs://chromium-skia-gm/skimage/output/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png
failed with retcode 2, try 1.
.

Expand Messages | Collapse Messages