Chromium Code Reviews| Index: Source/core/svg/SVGAngle.cpp |
| diff --git a/Source/core/svg/SVGAngle.cpp b/Source/core/svg/SVGAngle.cpp |
| index 7e91ef5049b310d911a361c838d39a01af558d6f..3396e3c4f12a8498b42f22670b8e6ce8383ed4b5 100644 |
| --- a/Source/core/svg/SVGAngle.cpp |
| +++ b/Source/core/svg/SVGAngle.cpp |
| @@ -117,6 +117,8 @@ float SVGAngle::value() const |
| return grad2deg(m_valueInSpecifiedUnits); |
| case SVG_ANGLETYPE_RAD: |
| return rad2deg(m_valueInSpecifiedUnits); |
| + case SVG_ANGLETYPE_TURN: |
| + return turn2deg(m_valueInSpecifiedUnits); |
| case SVG_ANGLETYPE_UNSPECIFIED: |
| case SVG_ANGLETYPE_UNKNOWN: |
| case SVG_ANGLETYPE_DEG: |
| @@ -136,6 +138,9 @@ void SVGAngle::setValue(float value) |
| case SVG_ANGLETYPE_RAD: |
| m_valueInSpecifiedUnits = deg2rad(value); |
| break; |
| + case SVG_ANGLETYPE_TURN: |
| + m_valueInSpecifiedUnits = deg2turn(value); |
| + break; |
| case SVG_ANGLETYPE_UNSPECIFIED: |
| case SVG_ANGLETYPE_UNKNOWN: |
| case SVG_ANGLETYPE_DEG: |
| @@ -181,6 +186,8 @@ static SVGAngle::SVGAngleType stringToAngleType(const CharType*& ptr, const Char |
| if (firstChar == 'g' && secondChar == 'r' && thirdChar == 'a' && fourthChar == 'd') |
| return SVGAngle::SVG_ANGLETYPE_GRAD; |
| + if (firstChar == 't' && secondChar == 'u' && thirdChar == 'r' && fourthChar == 'n') |
| + return SVGAngle::SVG_ANGLETYPE_TURN; |
| return SVGAngle::SVG_ANGLETYPE_UNKNOWN; |
| } |
| @@ -200,6 +207,10 @@ String SVGAngle::valueAsString() const |
| DEFINE_STATIC_LOCAL(String, gradString, ("grad")); |
| return String::number(m_valueInSpecifiedUnits) + gradString; |
| } |
| + case SVG_ANGLETYPE_TURN: { |
| + DEFINE_STATIC_LOCAL(String, turnString, ("turn")); |
| + return String::number(m_valueInSpecifiedUnits) + turnString; |
| + } |
| case SVG_ANGLETYPE_UNSPECIFIED: |
| case SVG_ANGLETYPE_UNKNOWN: |
| return String::number(m_valueInSpecifiedUnits); |
| @@ -271,6 +282,24 @@ void SVGAngle::convertToSpecifiedUnits(SVGAngleType unitType, ExceptionState& ex |
| return; |
| switch (m_unitType) { |
| + case SVG_ANGLETYPE_TURN: |
| + switch (unitType) { |
| + case SVG_ANGLETYPE_GRAD: |
| + m_valueInSpecifiedUnits = deg2grad(turn2deg(m_valueInSpecifiedUnits)); |
|
pdr.
2014/06/02 13:56:49
Is this just m_valueInSpecifiedUnits * 400? Could
Erik Dahlström (inactive)
2014/06/03 15:30:29
Done.
|
| + break; |
| + case SVG_ANGLETYPE_UNSPECIFIED: |
| + case SVG_ANGLETYPE_DEG: |
| + m_valueInSpecifiedUnits = turn2deg(m_valueInSpecifiedUnits); |
| + break; |
| + case SVG_ANGLETYPE_RAD: |
| + m_valueInSpecifiedUnits = deg2rad(turn2deg(m_valueInSpecifiedUnits)); |
| + break; |
| + case SVG_ANGLETYPE_TURN: |
| + case SVG_ANGLETYPE_UNKNOWN: |
| + ASSERT_NOT_REACHED(); |
| + break; |
| + } |
| + break; |
| case SVG_ANGLETYPE_RAD: |
| switch (unitType) { |
| case SVG_ANGLETYPE_GRAD: |
| @@ -280,6 +309,9 @@ void SVGAngle::convertToSpecifiedUnits(SVGAngleType unitType, ExceptionState& ex |
| case SVG_ANGLETYPE_DEG: |
| m_valueInSpecifiedUnits = rad2deg(m_valueInSpecifiedUnits); |
| break; |
| + case SVG_ANGLETYPE_TURN: |
| + m_valueInSpecifiedUnits = deg2turn(rad2deg(m_valueInSpecifiedUnits)); |
| + break; |
| case SVG_ANGLETYPE_RAD: |
| case SVG_ANGLETYPE_UNKNOWN: |
| ASSERT_NOT_REACHED(); |
| @@ -295,6 +327,9 @@ void SVGAngle::convertToSpecifiedUnits(SVGAngleType unitType, ExceptionState& ex |
| case SVG_ANGLETYPE_DEG: |
| m_valueInSpecifiedUnits = grad2deg(m_valueInSpecifiedUnits); |
| break; |
| + case SVG_ANGLETYPE_TURN: |
| + m_valueInSpecifiedUnits = deg2turn(grad2deg(m_valueInSpecifiedUnits)); |
| + break; |
| case SVG_ANGLETYPE_GRAD: |
| case SVG_ANGLETYPE_UNKNOWN: |
| ASSERT_NOT_REACHED(); |
| @@ -311,6 +346,9 @@ void SVGAngle::convertToSpecifiedUnits(SVGAngleType unitType, ExceptionState& ex |
| case SVG_ANGLETYPE_GRAD: |
| m_valueInSpecifiedUnits = deg2grad(m_valueInSpecifiedUnits); |
| break; |
| + case SVG_ANGLETYPE_TURN: |
| + m_valueInSpecifiedUnits = deg2turn(m_valueInSpecifiedUnits); |
| + break; |
| case SVG_ANGLETYPE_UNSPECIFIED: |
| break; |
| case SVG_ANGLETYPE_DEG: |