[SVG2] Add support for the 'turn' unit in <angle>.

Source/core/svg/SVGAngleTearOff.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/svg/SVGAngleTearOff.h"
 
 #include "bindings/v8/ExceptionState.h"
+#include "bindings/v8/ExceptionStatePlaceholder.h"
 #include "core/dom/ExceptionCode.h"
 
 namespace WebCore {
 
 SVGAngleTearOff::SVGAngleTearOff(PassRefPtr<SVGAngle> targetProperty, SVGElement* contextElement, PropertyIsAnimValType propertyIsAnimVal, const QualifiedName& attributeName)
     : SVGPropertyTearOff<SVGAngle>(targetProperty, contextElement, propertyIsAnimVal, attributeName)
 {
     ScriptWrappable::init(this);
 }
 
@@ skipping 56 matching lines @@
         commitChange();
 }
 
 void SVGAngleTearOff::setValueAsString(const String& value, ExceptionState& exceptionState)
 {
     if (isImmutable()) {
         exceptionState.throwDOMException(NoModificationAllowedError, "The attribute is read-only.");
         return;
     }
 
+    String old = target()->valueAsString();

[fs, 2014/06/11 07:29:07]

Nit: s/old/oldValue/ (or something)

[Erik Dahlström (inactive), 2014/06/11 08:04:25]

Done.

+
     target()->setValueAsString(value, exceptionState);
+
+    if (!exceptionState.hadException() && !hasExposedAngleUnit()) {
+        target()->setValueAsString(old, IGNORE_EXCEPTION); // rollback to old value

[fs, 2014/06/11 07:29:07]

Nit: ASSERT_NO_EXCEPTION might be even better?

[Erik Dahlström (inactive), 2014/06/11 08:04:25]

Done.

+        exceptionState.throwDOMException(SyntaxError, "The value provided ('" + value + "') is invalid.");
+        return;
+    }
+
     commitChange();
 }
 
 }