[SVG2] Add support for the 'turn' unit in <angle>.

Source/core/svg/SVGAngleTearOff.h

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
     enum {
         SVG_ANGLETYPE_UNKNOWN = SVGAngle::SVG_ANGLETYPE_UNKNOWN,
         SVG_ANGLETYPE_UNSPECIFIED = SVGAngle::SVG_ANGLETYPE_UNSPECIFIED,
         SVG_ANGLETYPE_DEG = SVGAngle::SVG_ANGLETYPE_DEG,
         SVG_ANGLETYPE_RAD = SVGAngle::SVG_ANGLETYPE_RAD,
         SVG_ANGLETYPE_GRAD = SVGAngle::SVG_ANGLETYPE_GRAD
     };
 
     virtual ~SVGAngleTearOff();
 
-    unsigned short unitType() { return target()->unitType(); }
+    unsigned short unitType() { return isValidAngle() ? target()->unitType() : SVGAngle::SVG_ANGLETYPE_UNKNOWN; }
 
     void setValue(float, ExceptionState&);
     float value() { return target()->value(); }
 
     void setValueInSpecifiedUnits(float, ExceptionState&);
     float valueInSpecifiedUnits() { return target()->valueInSpecifiedUnits(); }
 
     void newValueSpecifiedUnits(unsigned short unitType, float valueInSpecifiedUnits, ExceptionState&);
     void convertToSpecifiedUnits(unsigned short unitType, ExceptionState&);
 
-    String valueAsString() { return target()->valueAsString(); }
+    String valueAsString() { return isValidAngle() ? target()->valueAsString() : String::number(0); }

[krit, 2014/06/10 11:45:48]

Exposing more unit types is one thing. Do we need to be restrictive on
valueAsString? 

[Erik Dahlström (inactive), 2014/06/10 16:57:42]

Not necessarily, only if we want to preserve existing (public) behavior.

The spec is fairly clear on what should happen ("SVGAngle.valueAsString: The
angle value as a string value, in the units expressed by unitType.")

Since unitType is "unknown" the returned string is the default value (0 in this
case).

     void setValueAsString(const String&, ExceptionState&);
 
+    bool isValidAngle() { return target()->unitType() <= SVGAngle::SVG_ANGLETYPE_GRAD; }

[fs, 2014/06/10 11:13:30]

Nit: isValidAngleType / isValidAngleUnit ?

(Could be private and const?)

[Erik Dahlström (inactive), 2014/06/10 16:57:42]

Private yes, const no, the target() method is non-const.

[fs, 2014/06/11 07:29:07]

Ok.

+
 private:
     SVGAngleTearOff(PassRefPtr<SVGAngle>, SVGElement*, PropertyIsAnimValType, const QualifiedName&);
 };
 
 } // namespace WebCore
 
 #endif // SVGAngleTearOff_h_